fix(spaces): clearer base-directories UX - #180
Merged
Merged
Conversation
Reworks the base-dir config surface after review: - Open it by clicking the space name (now a button) or a labeled "Base directories" link on the card — not an unlabeled folder icon. - The modal leads with the existing paths, each removable in one click. - "Add folder…" is a clearly-optional dashed action, not the only button. - A "Done" button (plus X / Esc / backdrop) closes without adding anything. Test: SpaceBaseDirsModal — lists paths, one-click remove, Done closes without adding, renders nothing with no space. Signed-off-by: Mohammod Al Amin Ashik <maa.ashik00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #179 — the base-directories config was clumsy. This makes it obvious.
Changes
Test
SpaceBaseDirsModal.test.tsx— lists the space's paths, one-click remove, Done closes without calling add, and renders nothing when no space is selected. Full TS suite green (212).Frontend-only; no Rust changes.